Conversation
lmgeorge
force-pushed
the
lmgeorge/LG-15974/add_document_type_column_to_in_person_enrollments
branch
from
9e06e4c to
6bd19e3
Compare
There was a problem hiding this comment.
Is it possible to specify a default value for the new column and then remove the need to run a roll plan that backfills existing data? PostgreSQL docs suggest it's possible. Curious what you think.
There was a problem hiding this comment.
Good question! Having a default value would make investigations/debugging much harder when tracing failures, so I was specifically opting to not use a default value here as it would require a second migration to remove the default value option at an unpredictable later date.
There was a problem hiding this comment.
Thanks for explaining!
(This isn't a blocking question for this PR. It's more of a question for the overall work on LG-15974.) I'm curious if you're planning on leaving the column nullable after running the roll plan, or if you're planning on making it non-nullable?
It could be nice to have a more descriptive comment in the schema. This is also non-blocking.
There was a problem hiding this comment.
Thank you for the great callouts! Will add the descriptive comment piece as an AC to the third subtask (backfilling the values).
I'm curious if you're planning on leaving the column nullable after running the roll plan, or if you're planning on making it non-nullable?
It makes sense to leave it nullable, but this could change depending on what comes out of technical (re-) refinement.
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Looks good from my end! Good work! 👍🏻
db/primary_migrate/20250421182407_add_document_type_to_in_person_enrollments.rb
Outdated
Show resolved
Hide resolved
Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog]
lmgeorge
force-pushed
the
lmgeorge/LG-15974/add_document_type_column_to_in_person_enrollments
branch
from
6bd19e3 to
c2ad4b0
Compare
lmgeorge
deleted the
lmgeorge/LG-15974/add_document_type_column_to_in_person_enrollments
branch
|
Approved! I just tested it locally! Nice work @lmgeorge !! 💯 (I know you just merged it but thought I would commented) |
Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog]
Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog]
Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog]
update config update connector update identity config LG-15974: Add document_type to in_person_enrollments table (#12096) Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog] files Add table to record user confirmation of duplicate profiles (#12081) changelog: Upcoming Features, One Account, Add table to record user confirmation of duplicate profiles LG-15974: Add document_type to in_person_enrollments table (#12096) Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog] files LG-15974: Add document_type to in_person_enrollments table (#12096) Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog] config turn off config turn off config update turn off health check update config stop data-warehouse undo gem blank model turn on the WAR HOUSE gemfile lock update typo turn off warehouse turn off remove dw ref undo adapter redshift again update the WARHOUSE use store update config redshift maybe report house make instance update prefix update configuration hash ssl mode root cert, search paths rm ssl rm unused controller
update config update connector update identity config LG-15974: Add document_type to in_person_enrollments table (#12096) Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog] files Add table to record user confirmation of duplicate profiles (#12081) changelog: Upcoming Features, One Account, Add table to record user confirmation of duplicate profiles LG-15974: Add document_type to in_person_enrollments table (#12096) Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog] files LG-15974: Add document_type to in_person_enrollments table (#12096) Used to pass the type of ID to downstream IPP vendor Sub-task: LG-16126 [skip changelog] config turn off config turn off config update turn off health check update config stop data-warehouse undo gem blank model turn on the WAR HOUSE gemfile lock update typo turn off warehouse turn off remove dw ref undo adapter redshift again update the WARHOUSE use store update config redshift maybe report house make instance update prefix update configuration hash ssl mode root cert, search paths rm ssl rm unused controller
4 participants
🎫 Ticket
Link to the relevant ticket:
LG-15974
🛠 Summary of changes
Adds a new, unindexed
document_typecolumn to in_person_enrollments to pass along the type of photo ID used for an in-person proofing enrollment to our vendors.